Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix country chip #2969

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Jun 12, 2024

Description

Location string had spaces in it. Checked for the length after trimming the string.

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Zainab :)

@zaelgohary zaelgohary merged commit b17a71c into development_2.6 Jun 13, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_2.6_fix_country_chip branch June 13, 2024 06:44
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants